Add support for XREADGROUP CLAIM arg #3486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-TODO-rov
force-pushed
the
xreadgorup-claim
branch
from
19e2d4b to
afc4947
Compare
a-TODO-rov
requested review from
Copilot,
ggivo and
tishun
and removed request for
ggivo,
tishun and
uglide
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for Redis XREADGROUP CLAIM functionality, allowing the claiming of idle pending messages from a stream's Pending Entries List (PEL) with a configurable minimum idle time. The implementation introduces delivery metadata tracking for claimed entries.
- Adds
XReadArgs.claim()methods to specify minimum idle time for claiming entries - Introduces
ClaimedStreamMessageclass to carry metadata (milliseconds since last delivery and redelivery count) - Updates
StreamReadOutputto parse optional metadata fields from Redis responses - Adds comprehensive unit and integration tests
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/io/lettuce/core/XReadArgs.java | Adds claim() builder and instance methods to configure CLAIM min-idle-time parameter |
| src/main/java/io/lettuce/core/StreamMessage.java | Adds isClaimed() method to distinguish claimed entries from fresh ones |
| src/main/java/io/lettuce/core/ClaimedStreamMessage.java | New class extending StreamMessage to hold claim metadata (redelivery count and time since last delivery) |
| src/main/java/io/lettuce/core/output/StreamReadOutput.java | Updates output parser to handle optional metadata fields for claimed entries in both integer and bulk string formats |
| src/test/java/io/lettuce/core/output/StreamReadOutputUnitTests.java | Adds unit tests for parsing claimed entries with metadata in various formats |
| src/test/java/io/lettuce/core/XReadGroupClaimIntegrationTests.java | New integration test suite validating CLAIM behavior with real Redis server |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/test/java/io/lettuce/core/XReadGroupClaimIntegrationTests.java
Outdated
Show resolved
Hide resolved
src/test/java/io/lettuce/core/XReadGroupClaimIntegrationTests.java
Outdated
Show resolved
Hide resolved
a-TODO-rov
commented
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #3482